UPSTREAM: 41864: Allow 'kubectl drain --force' to remove orphaned pods#13123
Merged
openshift-bot merged 1 commit intoopenshift:release-1.5from Mar 1, 2017
marun:kubectl-drain-orphans
Merged
UPSTREAM: 41864: Allow 'kubectl drain --force' to remove orphaned pods#13123openshift-bot merged 1 commit intoopenshift:release-1.5from marun:kubectl-drain-orphans
openshift-bot merged 1 commit intoopenshift:release-1.5from
marun:kubectl-drain-orphans
Conversation
Member
|
lgtm [merge] |
Member
|
Contributor
Author
|
Fixed. |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
|
Evaluated for origin test up to af13e07 |
Contributor
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/629/) (Base Commit: f82baba) |
Member
|
[merge] because device mapper is the worst |
Contributor
|
Evaluated for origin merge up to af13e07 |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/690/) (Base Commit: ceb2cf3) (Image: devenv-rhel7_6008) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the managing resource of a given pod (e.g. DaemonSet/ReplicaSet/etc) is deleted (effectively orphaning the pod), and kubectl drain --force is invoked on the node hosting the pod, the command would fail with an error indicating that the managing resource was not found. This PR reduces the error to a warning if --force is specified, allowing nodes with orphaned pods to be drained.
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1424678