Skip to content

Pullthrough typos in oc tag#13015

Merged
openshift-bot merged 2 commits intoopenshift:masterfrom
soltysh:tag_typo
Feb 21, 2017
Merged

Pullthrough typos in oc tag#13015
openshift-bot merged 2 commits intoopenshift:masterfrom
soltysh:tag_typo

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 20, 2017

@miminar you've pointed that in #12862 (comment)
@mfojtik for approval

@mfojtik
Copy link
Contributor

mfojtik commented Feb 20, 2017

@soltysh need to run doc update generators, LGTM otherwise and thanks for fixing this :)

@soltysh
Copy link
Contributor Author

soltysh commented Feb 20, 2017

Generated changes added. Merging based on previous approval, besides this is just typo.

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/371/) (Base Commit: 3ef5377) (Image: devenv-rhel7_5945)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8dd4472

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8dd4472

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/371/) (Base Commit: 3ef5377)

Copy link

@miminar miminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@openshift-bot openshift-bot merged commit 796a323 into openshift:master Feb 21, 2017
@soltysh soltysh deleted the tag_typo branch February 21, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants