Skip to content

Only build images during build-cross#1241

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
ironcladlou:build-optimization
Mar 6, 2015
Merged

Only build images during build-cross#1241
openshift-bot merged 1 commit intoopenshift:masterfrom
ironcladlou:build-optimization

Conversation

@ironcladlou
Copy link
Contributor

Using build-go should only build the primary binaries. The only place
where image binaries need to be built is during build-cross via
the release image.

Removing the image binaries from build-go speeds up typical local builds.

Closes #1044

@ironcladlou
Copy link
Contributor Author

@smarterclayton @mfojtik I think this is all it takes. [test]

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1127/) (Image: devenv-fedora_988)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1247/)

Using build-go should only build the primary binaries. The only place
where image binaries need to be built is during build-cross via
the release image.

Removing the image binaries from build-go speeds up typical local builds.

Closes openshift#1044
@ironcladlou
Copy link
Contributor Author

@smarterclayton not sure what's going on with that merge run yet, and my test run passed... rebased and am letting the tests run again.

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 42547b4

openshift-bot pushed a commit that referenced this pull request Mar 6, 2015
@openshift-bot openshift-bot merged commit e22dc5a into openshift:master Mar 6, 2015
@ironcladlou ironcladlou deleted the build-optimization branch March 9, 2015 13:59
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Oct 10, 2017
…service-catalog/' changes from 7011d9e816..a385bb3f67

a385bb3f67 carry: Set external plan name for service-catalog walkthrough
3ec9e5b07a origin build: add origin tooling
8bb631f v0.1.0-rc1 chart updates (openshift#1359)
400e37f Move API to v1beta1 (openshift#1356)
8f55a99 0.0.24 chart updates (openshift#1357)
7ebb8ae Rename Service[Broker|Class|Plan]Status => ClusterService... (openshift#1349)
82a6103 Detect removed catalog entries (openshift#1353)
85125fd Refactor instance spec (openshift#1350)
99c0644 Update to Kubernetes 1.8 (openshift#1334)
a537490 Reformatting printed messages for controller_instance (openshift#1341)
0763ac0 Use field selector for broker delete (openshift#1348)
93fb0e5 remaining renames from ServiceInstanceCredential to ServiceBinding (openshift#1347)
cfdb2ed add text about how updating secrets/params require a 'poke' (openshift#1337)
1d04776 Change PresentInCatalog -> MissingFromBrokerCatalog (openshift#1342)
c95309c Update Service[Broker|Class|Plan] to ClusterService[Broker|Class|Plan] (openshift#1345)
9365039 Fix controller binding queue name, update documents (openshift#1344)
6375eb3 Do not set Ready/False condition in API Server when updating an instance. (openshift#1335)
108f05d Merge branch 'pr/1340'
bd0cb7b gofmt
e0ce4b5 Jenkins modifications
9341cbf unit and integration tests pass
076bfb2 Disambiguate k8s and external names in log messages for broker (openshift#1336)
c59e1e5 types.go changes for review
4ceaaab Rename resources from Service[Class|Plan]  to ClusterService[Class|Plan] (openshift#1327)
556c7d8 Add status.presentInCatalog field to service/plan (openshift#1328)
a6ad96a openshift#1148: Support updates to Instances (openshift#1289)
e36d286 fix RBAC resource names for ClusterServiceBroker (openshift#1330)
78d09ae add timeout (openshift#1326)
92ac8b5 Address comments raised after 1305 was merged (openshift#1321)
aca7543 Rename ServiceBroker to ClusterServiceBroker (openshift#1319)
a2b6ac0 Implementation for binding orphan mitigation (openshift#1241)
bffe4de Chart updates for 0.0.23 release (openshift#1325)
REVERT: 7011d9e816 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: a385bb3f67480a3c49b65b16c1d631b4d5fb5988
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Oct 10, 2017
…service-catalog/' changes from 7011d9e816..3aacfedec6

3aacfedec6 carry: Set external plan name for service-catalog walkthrough
3ec9e5b07a origin build: add origin tooling
8bb631f v0.1.0-rc1 chart updates (openshift#1359)
400e37f Move API to v1beta1 (openshift#1356)
8f55a99 0.0.24 chart updates (openshift#1357)
7ebb8ae Rename Service[Broker|Class|Plan]Status => ClusterService... (openshift#1349)
82a6103 Detect removed catalog entries (openshift#1353)
85125fd Refactor instance spec (openshift#1350)
99c0644 Update to Kubernetes 1.8 (openshift#1334)
a537490 Reformatting printed messages for controller_instance (openshift#1341)
0763ac0 Use field selector for broker delete (openshift#1348)
93fb0e5 remaining renames from ServiceInstanceCredential to ServiceBinding (openshift#1347)
cfdb2ed add text about how updating secrets/params require a 'poke' (openshift#1337)
1d04776 Change PresentInCatalog -> MissingFromBrokerCatalog (openshift#1342)
c95309c Update Service[Broker|Class|Plan] to ClusterService[Broker|Class|Plan] (openshift#1345)
9365039 Fix controller binding queue name, update documents (openshift#1344)
6375eb3 Do not set Ready/False condition in API Server when updating an instance. (openshift#1335)
108f05d Merge branch 'pr/1340'
bd0cb7b gofmt
e0ce4b5 Jenkins modifications
9341cbf unit and integration tests pass
076bfb2 Disambiguate k8s and external names in log messages for broker (openshift#1336)
c59e1e5 types.go changes for review
4ceaaab Rename resources from Service[Class|Plan]  to ClusterService[Class|Plan] (openshift#1327)
556c7d8 Add status.presentInCatalog field to service/plan (openshift#1328)
a6ad96a openshift#1148: Support updates to Instances (openshift#1289)
e36d286 fix RBAC resource names for ClusterServiceBroker (openshift#1330)
78d09ae add timeout (openshift#1326)
92ac8b5 Address comments raised after 1305 was merged (openshift#1321)
aca7543 Rename ServiceBroker to ClusterServiceBroker (openshift#1319)
a2b6ac0 Implementation for binding orphan mitigation (openshift#1241)
bffe4de Chart updates for 0.0.23 release (openshift#1325)
REVERT: 7011d9e816 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 3aacfedec6f8d3d07a5b922e0fcd4a9b28a0e5d2
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
* Implement orphan mitigation for bindings

This adds support for handling orphaned service instance credentials (or
bindings) in the reconcile loop.

Issue openshift#989

* Generated files
Miciah pushed a commit to Miciah/origin that referenced this pull request Jun 27, 2018
[3.9] Ensure Continue token is proxied for openshift RBAC list calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building OpenShift took longer than before

3 participants