Allow to unlink deleted secrets from a service account#11868
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Dec 15, 2016
Merged
Allow to unlink deleted secrets from a service account#11868openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
[test] |
mfojtik
force-pushed
the
unlink-deleted-secrets
branch
from
e30bdec to
94acadc
Compare
mfojtik
force-pushed
the
unlink-deleted-secrets
branch
from
94acadc to
4443e8f
Compare
Contributor
|
Evaluated for origin test up to 4443e8f |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11364/) (Base Commit: ab8b232) |
Member
|
LGTM |
Contributor
Author
|
will wait for 1.5 to merge. |
Contributor
Author
|
[merge] |
Contributor
Author
|
flake: #10773 [merge] |
Contributor
|
Evaluated for origin merge up to 4443e8f |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12415/) (Base Commit: da967d5) (Image: devenv-rhel7_5550) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11851
@fabianofranz PTAL this improves a logic around linking/unlinking the secrets a little bit: