UPSTREAM: 34028: Add --dry-run option to oc create sub-commands#11238
Conversation
oc create sub-commandsoc create sub-commands
|
@openshift/cli-review PTAL |
oc create sub-commandsoc create sub-commands
|
Once kubernetes/kubernetes#34502 and #10993 merges, we could add a |
|
Overall LGTM, let's see how upstream goes. |
|
@fabianofranz Sounds good, thanks for taking a look! I've added the |
09a947f to
f8e27a0
Compare
Adds `--dry-run` option to create/deploymenrconfig, create/identity.go, create/imagestream.go, create/user.go, user_identity_mapping.go
f8e27a0 to
2369eab
Compare
|
@fabianofranz Upstream merged! kubernetes/kubernetes#34028 |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10120/) (Image: devenv-rhel7_5206) |
|
Evaluated for origin merge up to 18d604e |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 18d604e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10120/) (Base Commit: 92a71d4) |
|
|
|
@smarterclayton thanks, will address this |
UPSTREAM: kubernetes/kubernetes#34028
Fixes #10426
List of commands to address:
oc create [-f ...]oc create clusterresourcequotaoc create deploymentconfigoc create identityoc create imagestreamoc create policybindingoc create routeoc create useroc create useridentitymappingcc @openshift/cli-review @smarterclayton