UPSTREAM: 30624: Node controller deletePod return true if there are pods pending deletion#10503
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Aug 18, 2016
Merged
Conversation
…ods pending deletion If a node had a single pod in terminating state, and that node no longer reported healthy, the pod was never deleted by the node controller because it believed there were no pods remaining.
Contributor
Author
|
[test] |
Contributor
Author
|
This is currently 9th in the Kube submit queue |
Contributor
Author
|
[test] |
Contributor
|
Evaluated for origin test up to 7da945e |
Member
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8160/) (Image: devenv-rhel7_4870) |
Contributor
|
Evaluated for origin merge up to 7da945e |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8160/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a node had a single pod in terminating state, and that node no longer reported healthy, the pod
was never deleted by the node controller because it believed there were no pods remaining.
@derekwaynecarr I went ahead and picked this for you