Enable replicasets and deployments#10136
Conversation
|
[test] |
| authorizationapi.NewRule(read...).Groups(batchGroup).Resources("jobs").RuleOrDie(), | ||
|
|
||
| authorizationapi.NewRule(read...).Groups(extensionsGroup).Resources("jobs", "horizontalpodautoscalers").RuleOrDie(), | ||
| authorizationapi.NewRule(read...).Groups(extensionsGroup).Resources("jobs", "horizontalpodautoscalers", "replicasets", "replicasets/scale").RuleOrDie(), |
There was a problem hiding this comment.
test to catch drift there would be good (as a follow up)
There was a problem hiding this comment.
test to catch drift there would be good
It exists. It'll yell in a minute.
There was a problem hiding this comment.
add to cluster reader
Also, it already exists in cluster-reader.
mfojtik
changed the title
|
re[test] |
| Name: DeploymentControllerRoleName, | ||
| }, | ||
| Rules: []authorizationapi.PolicyRule{ | ||
| { |
|
LGTM (I think we should have some test-cmd as well to prove the scale works, but I can do that as follow up). |
|
[merge] |
|
Evaluated for origin test up to ae50ea2 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7301/) (Image: devenv-rhel7_4716) |
|
Evaluated for origin merge up to ae50ea2 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7301/) |
| authorizationapi.ClusterRole{ | ||
| ObjectMeta: kapi.ObjectMeta{ | ||
| Name: DeploymentControllerRoleName, | ||
| Name: DeploymentConfigControllerRoleName, |
There was a problem hiding this comment.
This is not the deployment config controller but our custom replication controller controller
6 participants
Enables RSs and Ds without cohabitation.
@mfojtik