Let users add config maps and secrets as volumes#891
Let users add config maps and secrets as volumes#891openshift-bot merged 2 commits intoopenshift:masterfrom
Conversation
spadgett
force-pushed
the
add-config-map-secret-volume
branch
2 times, most recently
from
c961884 to
5f43d1e
Compare
jwforres
left a comment
jwforres
left a comment
There was a problem hiding this comment.
one minor comment, otherwise LGTM. lets wait to merge till after the design meeting today
app/scripts/filters/util.js
Outdated
| }) | ||
| .filter('keys', function() { | ||
| return function(obj) { | ||
| if (!obj) { |
There was a problem hiding this comment.
what about return _.keys(obj);
spadgett
force-pushed
the
add-config-map-secret-volume
branch
from
5f43d1e to
8e7b54f
Compare
|
@jwforres updated with a second commit for removing volumes |
| } | ||
|
|
||
| var triggers = _.get($scope, 'deploymentConfig.spec.triggers', []); | ||
| return _.some(triggers, { type: 'ConfigChange' }); |
There was a problem hiding this comment.
should you be checking automatic true?
There was a problem hiding this comment.
not for config change, only image change
| $scope.removeVolume = function(volume) { | ||
| var details; | ||
| if (isConfigChangeActive()) { | ||
| details = "This will remove the volume from the deployment config and trigger a new deployment."; |
There was a problem hiding this comment.
should we be clear that it will not delete the PVC/Secret/ConfigMap?
spadgett
force-pushed
the
add-config-map-secret-volume
branch
from
8e7b54f to
40eedd8
Compare
|
@jwforres updated |
|
[merge] |
|
Evaluated for origin web console merge up to 40eedd8 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/755/) (Base Commit: bc496f8) |
3 participants
https://trello.com/c/gUzfL5OA
@jwforres PTAL
Add all keys:
Add specific keys: