Correct ProjectNameTaken error handling in various add-to-projects wizards#2473
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Nov 8, 2017
Merged
Conversation
openshift-ci-robot
added
the
size/L
spadgett
reviewed
Nov 7, 2017
Member
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
Generally LGTM, just a few small comments
app/scripts/directives/fromFile.js
Outdated
| $scope.noProjectsCantCreate = true; | ||
| }); | ||
|
|
||
| $scope.projectNameTaken = false; |
Member
There was a problem hiding this comment.
Shouldn't need to initialize here since the $watch below is called immediately and will set it to false.
| NotificationsService.addNotification({ | ||
| id: "deploy-image-create-project-error", | ||
| type: "error", | ||
| message: "An error occurred creating project", |
Member
There was a problem hiding this comment.
We make the message a complete sentence with punctuation when possible.
"An error occurred creating project."
app/scripts/directives/fromFile.js
Outdated
| NotificationsService.addNotification({ | ||
| id: "import-create-project-error", | ||
| type: "error", | ||
| message: "An error occurred creating project", |
Member
There was a problem hiding this comment.
"An error occurred creating project."
Member
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
…te, and fromFile wizards
dtaylor113
force-pushed
the
projectNameTaken
branch
from
2cc4579 to
6494391
Compare
Member
|
/lgtm |
Contributor
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated deployImage, processTemplate, and fromFile wizards.
Fixes #1955