Bug 1509142 - Should not display the 'Reveal Secret' link when secret is without 'data' field

[jhadvig]

@spadgett PTAL

[spadgett]

We should disable the "Add to Application" button if there is not data.

Can you check "Environment From" when you pick the secret? I suspect the view details dialog has the same problem.

[spadgett]

This is grammatically correct, but reads a little funny to me. Maybe use an empty state message?

<div ng-if="!secret.data" class="empty-state-message text-center">
  <h2>No data.</h2>
  <p>This secret has no data.</p>
</div>

[jhadvig]

@spadgett so you are right regarding the secret without data field in theEnvironment From... there is nothing to select in the value input.

Do we want to disable the value input in that case, or just set the placeholder to just say something like "No key" ?

[spadgett]

Do we want to disable the value input in that case, or just set the placeholder to just say something like "No key" ?

As long as it's not broken, we might just leave it for 3.7 and come back to it in 3.8.

cc @jwforres

[jwforres]

yeah if its not throwing a JS error i wouldnt touch that code in 3.7

[spadgett]

/kind bug
/lgtm

[spadgett]

/hold

[jhadvig]

@spadgett disabling the btn when no data

[spadgett]

/lgtm
/hold cancel

[openshift-merge-robot]

Automatic merge from submit-queue.