Show proper type of imported item in import wizard results#2415
Closed
jhadvig wants to merge 1 commit intoopenshift:masterfrom
Closed
Show proper type of imported item in import wizard results#2415jhadvig wants to merge 1 commit intoopenshift:masterfrom
jhadvig wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/S
Member
|
@jhadvig You and I are working on the same issues. I have some changes locally for this :/ I think it should say something like "Stateful set my-stateful-set created." I realize the "completed" wording is not new. |
Member
|
Maybe just "Resources created successfully." for a list? I know it might be hard to get these exact messages in |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the kind thats actually being created and not default "YAML / JSON"
Although not sure if in case of List we dont wanna print all the created resources from the List itself, but on the other hand we are not doing it with Templates.
@spadgett @rhamilto thoughts ?