[WIP] Fix nav style behavior around 'click'#2373
Closed
jwforres wants to merge 1 commit intoopenshift:masterfrom
Closed
[WIP] Fix nav style behavior around 'click'#2373jwforres wants to merge 1 commit intoopenshift:masterfrom
jwforres wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
Member
Author
|
Remaining issue is that when you active a left nav item using the keyboard instead of the mouse it still has this right border:
|
|
@jwforres: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sg00dwin
added a commit
to sg00dwin/origin-web-console
that referenced
this pull request
Oct 25, 2017
…t with tabbing through nav. Fixes openshift#2373 (comment)
openshift-merge-robot
added a commit
that referenced
this pull request
Oct 27, 2017
…e-2372 Automatic merge from submit-queue. Rework nav to remove :hover selectors to address bugs, inconsistencies Fixes #2373 Building on what @sg00dwin did in https://github.com/sg00dwin/origin-web-console/tree/vertical-nav-tab-issue2373%23issuecomment-339359101, this removes all :hover styling changes in order to forge consistency across hover, click, and tab navigation. @sg00dwin, @spadgett, mind pulling these changes, testing, and seeing if everything is ok?
f0x11
pushed a commit
to f0x11/origin-web-console
that referenced
this pull request
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2292