Disable service-instance delete link when already schedualed for deletion#2234
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 16, 2017
Merged
Conversation
openshift-ci-robot
added
the
size/XS
Member
|
LGTM |
cdcabrera
approved these changes
Oct 9, 2017
jeff-phillips-18
approved these changes
Oct 9, 2017
jhadvig
force-pushed
the
service-instance
branch
from
1a950e3 to
de3f783
Compare
Member
Author
|
.... adding dist |
jhadvig
force-pushed
the
service-instance
branch
from
de3f783 to
8a8c89a
Compare
|
Origin Web Console Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
openshift-bot
added
the
needs-rebase
Member
|
Hey @jhadvig I wasn't sure if you had been able to verify the fix or if we're still waiting? Let me know. It does need rebase now. |
spadgett
changed the title
jhadvig
force-pushed
the
service-instance
branch
from
8a8c89a to
e2b8980
Compare
openshift-merge-robot
removed
the
needs-rebase
Member
Author
|
@jeff-phillips-18 @spadgett I've tested the change and it works as expected. if the service-instance is deleted then the Screen: |
Member
|
/lgtm |
Member
|
Flake #1685 /retest |
Contributor
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@spadgett just FYI ... will properly test once the web-catalog is fixed
Closes #2227