Fix preferred version for service bindings#2233
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Oct 9, 2017
Merged
Fix preferred version for service bindings#2233openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
jeff-phillips-18
approved these changes
Oct 9, 2017
Member
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
Sorry, I missed it too.
I can go through the rest of console (and catalog?) looking for places not yet using the API service for resources and put up a PR if that's desired.
Member
Author
|
@jeff-phillips-18 Thanks. I found a few places in views that I need to change anyway for the SerivceBinding resource rename. I have them changed locally. |
spadgett
force-pushed
the
fix-bindings-preferred-version
branch
from
8f77a1c to
5f9e7da
Compare
Member
Author
|
[merge] |
|
Evaluated for origin web console merge up to 5f9e7da |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/325/) (Base Commit: ea7477e) (PR Branch Commit: 5f9e7da) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeff-phillips-18 FYI, missed this in #2155. PTAL