Vertically align close and kebab icons in notification drawer#2229
Conversation
openshift-ci-robot
added
the
size/S
rhamilto
left a comment
rhamilto
left a comment
There was a problem hiding this comment.
It seems like the close button visual treatment is different here (less opaque) than elsewhere (more opaque). And the close button on the drawer itself lacks a hover state.
app/styles/_notifications.less
Outdated
| margin-right: (@grid-gutter-width/(-4)); // vertically align with dropdown-kebab-pf | ||
| .pficon-close { | ||
| color: @color-pf-black-400; | ||
| &:hover,&:focus,&:active { |
There was a problem hiding this comment.
Nit: alpha and maybe put each selector on a separate line?
sg00dwin
force-pushed
the
notification-drawer-action-icon-alignment2218
branch
from
d2e6474 to
6744d66
Compare
|
@spadgett @rhamilto pr updated so
|
|
[test] Just need to see if Travis can start Chrome on other branches... |
|
Aha. e2e tests not running in Travis here. |
sg00dwin
force-pushed
the
notification-drawer-action-icon-alignment2218
branch
from
6744d66 to
b6216f7
Compare
openshift-ci-robot
added
size/M
|
@spadgett updated pr to use |
| type="button" | ||
| ng-if="!notification.actions.length" | ||
| ng-click="$ctrl.customScope.clear(notification, $index, notificationGroup)"> | ||
| <span class="sr-only">Clear notification</span> |
There was a problem hiding this comment.
Looks like you lost the sr-only text
Match kebab and close icon default color Fixes openshift#2218
sg00dwin
force-pushed
the
notification-drawer-action-icon-alignment2218
branch
from
b6216f7 to
3428927
Compare
|
Evaluated for origin web console test up to 3428927 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/325/) (Base Commit: 5e7f02a) (PR Branch Commit: 3428927) |
|
[merge] |
|
Origin Web Console Merge Results: Waiting: You are in the build queue at position: 1 |
|
Evaluated for origin web console merge up to 3428927 |
6 participants
Fixes #2218