Don't let users accidentally and permanently dismiss router hostname message#2194
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Sep 29, 2017
Merged
Conversation
…message Knowing the router hostname is vital for setting up a CNAME for routes with custom hosts. Remove the "Don't Show Me Again" link to prevent users from accidentally dismissing the message without being able to get it back.
jeff-phillips-18
approved these changes
Sep 29, 2017
Member
Author
|
[merge] |
|
Evaluated for origin web console merge up to bac657d |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/296/) (Base Commit: 002a70f) (PR Branch Commit: bac657d) |
|
Wow @spadgett you are on top of it! Much appreciated! EDIT: I don't think I dismissed it by the way. I'm pretty sure it was never there in the first place. If you look at my screenshot you'll see that the route was created '3 minutes ago'. I specifically created that application to test whether the message was appearing. It did not. Note that I'm working on Openshift Online v3. I'm not sure whether they customized the web console in some way or are on an older version maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowing the router hostname is vital for setting up a CNAME for routes
with custom hosts. Remove the "Don't Show Me Again" link to prevent
users from accidentally dismissing the message without being able to get
it back.
See #1194 (comment)
@Download FYI, we're also looking at the other feedback you've given.