Show "binding" as type in delete dialog#2143
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Sep 22, 2017
Merged
Conversation
`serviceinstancecredentials` was previously displayed as the type. Also the kind passed to `delete-link` should be `ServiceInstanceCredential`.
jeff-phillips-18
approved these changes
Sep 22, 2017
Member
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
LGTM. I will add another issue about displaying the wrong name.
Member
Author
|
[merge] |
|
Evaluated for origin web console merge up to 14d1180 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/253/) (Base Commit: be4c893) (PR Branch Commit: 14d1180) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serviceinstancecredentialswas previously displayed as the type. Also the kind passed todelete-linkshould beServiceInstanceCredential.Fixes #2142