Let administrators disable "Copy Login Command"#2107
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Sep 19, 2017
Merged
Let administrators disable "Copy Login Command"#2107openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Member
Author
|
Follow on to #1788 |
openshift-bot
added
the
needs-rebase
* Add a DISABLE_COPY_LOGIN_COMMAND constant that prevents users from copying a login command with their token. * Let users permanently dismiss the toast notification warning telling users not to share their token. * Update "Log Out" to use headline case like other menu items.
spadgett
force-pushed
the
disable-copy-login-command
branch
from
3780485 to
6fb94d8
Compare
spadgett
removed
the
needs-rebase
benjaminapetersen
approved these changes
Sep 19, 2017
Contributor
benjaminapetersen
left a comment
benjaminapetersen
left a comment
There was a problem hiding this comment.
LGTM, i think splitting the alert is clearer as well.
Member
Author
|
[merge] |
|
Evaluated for origin web console merge up to 6fb94d8 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/228/) (Base Commit: 6f40623) (PR Branch Commit: 6fb94d8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISABLE_COPY_LOGIN_COMMANDconstant that prevents users from copying a login command with their token.@wgordon17 @serenamarie125