Use metadata.name as secondary sort for projects#1081
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Jan 5, 2017
Merged
Use metadata.name as secondary sort for projects#1081openshift-bot merged 1 commit intoopenshift:masterfrom
metadata.name as secondary sort for projects#1081openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Update the projects page and `orderByDisplayName` filter to use `metadata.name` as a secondary sort when projects have the same display name.
benjaminapetersen
approved these changes
Jan 5, 2017
Contributor
benjaminapetersen
left a comment
benjaminapetersen
left a comment
There was a problem hiding this comment.
lgtm, works well when tested with 5 projects with 'Sorted project' as display name, but names of aaa,bbb,ccc,ddd,eee. Master does not sort consistently, this update does.
Member
Author
|
@benjaminapetersen thanks [merge] |
|
Evaluated for origin web console merge up to 42a1b98 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/902/) (Base Commit: 3656be7) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the projects page and
orderByDisplayNamefilter to usemetadata.nameas a secondary sort when projects have the same displayname.
Fixes #915