Updating fluentd docker container mount path

[ewolinetz]

To address https://trello.com/c/V5osNVuq/244-free-int-fluentd-not-running-due-to-var-lib-docker-containers-issue

cc @jupierce

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• roles/openshift_logging_fluentd/OWNERS [ewolinetz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ewolinetz]

/hold

This may not be something we actually need to change. The fix that this patches should actually be resolved at the lower level. Rich is digging up the discussion that was had surrounding this in a prior email thread.

[ewolinetz]

http://post-office.corp.redhat.com/archives/aos-devel/2018-April/msg00231.html

[ewolinetz]

cc @eparis @gnufied @jsafrane @vikram-redhat

[openshift-ci-robot]

@ewolinetz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/install	b83d581	link	/test install
ci/openshift-jenkins/gcp	b83d581	link	/test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gnufied]

Does fluentd pod works with either /var/lib/docker or /var/lib/docker/containers without any modification? I would expect these 2 directories to contain different content.

[gnufied]

My main concern same as before is - this will again break in future if docker deployment causes "/var/lib/docker" to be mounted as private mount.

Rather than doing this here - is it possible to disable MountPropagation feature from inventory file that deploys the cluster to free-int? I tried making the same change in openshift-ansible - #7936 but now that I think of, since we are rolling back "slave" mount propagation defaults in upstream, modifying openshift-ansible may not be the right place.

[gnufied]

Any change we make in openshift-ansible will be temporary(and not required) to fix this issue once openshift/origin#19364 PR merges. So it is best to workaround this by disabling MountPropagation feature via inventory file.

[jsafrane]

openshift/origin#19364 was merged into Origin 3.10, so this PR is probably not needed. Sorry it took so long.

[ewolinetz]

Closing as the origin fix for this has merged