[release-4.14] NO-JIRA: fix verify job failure#2584
[release-4.14] NO-JIRA: fix verify job failure#2584openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.14from
Conversation
|
@bertinatto: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
jira/valid-reference
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
changed the title
openshift-ci
bot
added
vendor-update
|
/test verify |
bertinatto
force-pushed
the
fix-verify-failure
branch
from
6dbcc8b to
385ae24
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
force-pushed
the
fix-verify-failure
branch
from
385ae24 to
a6dcfd6
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
force-pushed
the
fix-verify-failure
branch
from
892c284 to
a8b0c1a
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Has this been broken on 4.14 forever (https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-kubernetes-release-4.14-verify)? |
|
/test verify |
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
force-pushed
the
fix-verify-failure
branch
from
ddaa286 to
2656260
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
force-pushed
the
fix-verify-failure
branch
from
2656260 to
1a6d292
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
force-pushed
the
fix-verify-failure
branch
from
1a6d292 to
e1dcb4c
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Pinned these 2 deps because they are the last that support go 1.20, which we use in our CI: go mod edit -replace golang.org/x/mod=golang.org/x/mod@v0.20.0 go mod edit -replace golang.org/x/tools=golang.org/x/tools@v0.24.0
bertinatto
force-pushed
the
fix-verify-failure
branch
from
ab4c31c to
921ccdb
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
added
backport-risk-assessed
openshift-ci
bot
assigned
duanwei33,
gangwgr,
kasturinarra,
lyman9966,
wangke19,
xingxingxia and
zhouying7780
|
/override ci/prow/e2e-aws-ovn-serial This failure is being fixed in openshift/origin#30727 |
|
@bertinatto: Overrode contexts on behalf of bertinatto: ci/prow/e2e-aws-ovn-serial DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bertinatto: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm IIUC, we have skew between the Go toolchain version we're using to build 4.14 and the version upstream 1.27 was based on, and this is manifesting through update-vendor.sh selecting dependency versions that aren't compatible with our Go toolchain version. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bertinatto
added
the
jira/valid-bug
|
/verified by ci |
openshift-ci-robot
added
the
verified
|
@bertinatto: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 34441f4
into
openshift:release-4.14
10 participants
Pin
golang.org/x/modtov0.20.0andgolang.org/x/toolstov0.24.0using replace directives.These are the last versions that support Go 1.20, which is used in CI. Newer versions (x/mod v0.21.0+, x/tools v0.25.0+) require Go 1.22 and cause build failures.
CC @benluddy @p0lyn0mial