OCPBUGS-66338: UPSTREAM: 135629: selinux: Fix the controller to ignore finished pods

[jsafrane]

Let the SELinux warning controller ignore completed pods. This removes pods with unmounted volumes from SELinux warning events + metrics.

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-66338, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Let the SELinux warning controller ignore completed pods. This removes pods with unmounted volumes from SELinux warning events + metrics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• b76583d|UPSTREAM: 135629:selinux: Fix the controller to ignore finished pods: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[jsafrane]

/hold
for upstream merge. Just testing in OCP for now.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/hold cancel
The PR is merged and Kubernes 1.35 is out.

[jsafrane]

sorry, too early. It's not merged yet
/hold

[jsafrane]

It has been merged upstream and it will be part of 1.35.1

[openshift-ci-robot]

@jsafrane: the contents of this pull request could be automatically validated.

The following commits are valid:

• f0b3a9f|UPSTREAM: 135629: selinux: Fix the controller to ignore finished pods: the upstream PR kubernetes/kubernetes#135629 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[jsafrane]

/hold cancel

[openshift-ci-robot]

@jsafrane: the contents of this pull request could be automatically validated.

The following commits are valid:

• bbdf0eb|UPSTREAM: 135629: selinux: Fix the controller to ignore finished pods: the upstream PR kubernetes/kubernetes#135629 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	bbdf0eb	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-runc	bbdf0eb	link	true	/test e2e-aws-ovn-runc
ci/prow/e2e-aws-crun-wasm	bbdf0eb	link	true	/test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-serial-1of2	bbdf0eb	link	true	/test e2e-aws-ovn-serial-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.