Skip to content

Enable rhel 7.5 and docker 1.13#1061

Merged
jupierce merged 1 commit intoopenshift-eng:masterfrom
jupierce:docker_113
Apr 12, 2018
Merged

Enable rhel 7.5 and docker 1.13#1061
jupierce merged 1 commit intoopenshift-eng:masterfrom
jupierce:docker_113

Conversation

@jupierce
Copy link
Contributor

@jupierce jupierce commented Feb 2, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err, keep the dockertested for the 1.13 install

@jupierce
Copy link
Contributor Author

jupierce commented Feb 5, 2018

@stevekuznetsov If you insist on it working, fine.

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@0xmichalis
Copy link
Contributor

We failed to get the test suite passing with docker1.13 due to a websocket issue

openshift/origin#18726

@0xmichalis
Copy link
Contributor

We failed to get the test suite passing with docker1.13 due to a websocket issue

Seems to be fixed in openshift/origin#18755

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems scary if our AMI is still 7.4 yeah?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2018
@stevekuznetsov
Copy link
Contributor

/lgtm

@sdodson @jupierce can we yum upgrade from 7.4 to 7.5? If not we will need a new bare AMI

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2018
@sdodson
Copy link
Contributor

sdodson commented Apr 11, 2018

Should be able to yum upgrade. If not then there are problems.

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Apr 11, 2018

OK, will add a yum update to our AMI step

@jupierce jupierce merged commit cd41005 into openshift-eng:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants