Add ComboChart component with Storybook documentation#2146
Draft
rSnapkoOpenOps wants to merge 1 commit intochore/refactor-bar-chartsfrom
Draft
Add ComboChart component with Storybook documentation#2146rSnapkoOpenOps wants to merge 1 commit intochore/refactor-bar-chartsfrom
rSnapkoOpenOps wants to merge 1 commit intochore/refactor-bar-chartsfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ComboChart UI component (bar + line on dual Y-axes) and provides Storybook documentation for it, extending the existing chart component set in packages/ui-components.
Changes:
- Export
ComboChartfrom the chart module barrel (@/ui/chart). - Add
ComboChartcomponent built on RechartsComposedChart, reusing existingChartContainer/ tooltip / legend primitives. - Add Storybook stories demonstrating default usage and feature combinations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui-components/src/ui/chart/index.ts | Exposes the new ComboChart via the chart module exports. |
| packages/ui-components/src/ui/chart/combo-chart.tsx | Implements the ComboChart component using Recharts primitives and shared chart helpers. |
| packages/ui-components/src/stories/charts/combo-chart.stories.tsx | Adds Storybook documentation and example configurations for ComboChart. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+128
to
+129
| className={legendClassName} | ||
| content={<ChartLegendContent />} |
Comment on lines
+94
to
+121
| {showLeftYAxis && ( | ||
| <YAxis | ||
| yAxisId="left" | ||
| orientation="left" | ||
| tickFormatter={leftYAxisTickFormatter} | ||
| tickLine={false} | ||
| axisLine={false} | ||
| ticks={leftYAxisTicks} | ||
| domain={leftYAxisDomain} | ||
| tick={{ | ||
| fill: 'hsl(var(--foreground))', | ||
| }} | ||
| /> | ||
| )} | ||
| {showRightYAxis && ( | ||
| <YAxis | ||
| yAxisId="right" | ||
| orientation="right" | ||
| tickFormatter={rightYAxisTickFormatter} | ||
| tickLine={false} | ||
| axisLine={false} | ||
| ticks={rightYAxisTicks} | ||
| domain={rightYAxisDomain} | ||
| tick={{ | ||
| fill: 'hsl(var(--foreground))', | ||
| }} | ||
| /> | ||
| )} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OPS-3910