List the names of the failing benchmark subworkflows#2144
Open
List the names of the failing benchmark subworkflows#2144
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds display of failed benchmark subworkflow names when a benchmark run completes with partial failures.
Changes:
- New
FailedWorkflowsListcomponent to render failed workflow names as a bulleted list useBenchmarkRunhook tracks and exposesfailedWorkflowNamesstate- Wires the new prop through
BenchmarkWizardtoBenchmarkReadyStep
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
benchmark-ready-step.tsx |
Adds FailedWorkflowsList component and renders it in the succeeded_with_failures phase |
use-benchmark-run.ts |
Extracts failed subworkflow names from status response and exposes them |
benchmark-wizard.tsx |
Passes failedWorkflowNames prop to BenchmarkReadyStep |
use-benchmark-run.test.ts |
Adds test assertions for failedWorkflowNames |
benchmark-ready-step.stories.tsx |
Adds story args for failedWorkflowNames |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
cezudas
commented
Mar 17, 2026
| provider: string; | ||
| }) => ( | ||
| <div className="flex flex-col gap-3 py-2"> | ||
| <div className="flex flex-col gap-1 py-2"> |
Contributor
Author
There was a problem hiding this comment.
unrelated change: reduces vertical gaps between text and link to match Figma design
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3888.