8377309: Remove PhaseIterGVN::verify_Identity_for exclusion for Min/Max find identity op

[dev-jonghoonpark]

Summary

This PR removes the temporary exclusion logic for Min/Max nodes in PhaseIterGVN::verify_Identity_for.

With the fixes for JDK-8373134 and JDK-8374896, the iterative GVN can now correctly verify the identity of these nodes without triggering verification failures

Testing

Confirmed that the following tests pass on macosx-aarch64-server-fastdebug and linux-x86_64-server-fastdebug:

• compiler/codegen/TestBooleanVect.java with -XX:VerifyIterativeGVN=1110
• compiler/igvn/TestMinMaxIdentity.java with -XX:VerifyIterativeGVN=1110
• tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8377309: Remove PhaseIterGVN::verify_Identity_for exclusion for Min/Max find identity op (Enhancement - P4)

Reviewers

• Manuel Hässig (@mhaessig - Committer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29863/head:pull/29863
$ git checkout pull/29863

Update a local copy of the PR:
$ git checkout pull/29863
$ git pull https://git.openjdk.org/jdk.git pull/29863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29863

View PR using the GUI difftool:
$ git pr show -t 29863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29863.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8377309: Remove PhaseIterGVN::verify_Identity_for exclusion for Min/Max find identity op

Reviewed-by: mhaessig, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• 32a6197: 8370044: TraceBytecodes shouldn't break up lines
• c16ac37: 8376892: Allow conversion warnings in subsets of the code base
• 92fa4f1: 8372231: Test gtest/NMTGtests.java#nmt-summary crashed
• ... and 89 more: https://git.openjdk.org/jdk/compare/63f00fff921ed4ac0f595a0a013d399700433a2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mhaessig, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dev-jonghoonpark The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a4ba5c4e)

[mhaessig]

Nice catch! I kicked off a CI run and will report back with the results.

[chhagedorn]

Great, looks good, thanks! Let's wait for the results from @mhaessig.

[mhaessig]

Testing passed

[dev-jonghoonpark]

/integrate

[openjdk]

@dev-jonghoonpark
Your change (at version a4ba5c4) is now ready to be sponsored by a Committer.

[mhaessig]

/sponsor

[openjdk]

Going to push as commit f1169f9.
Since your change was applied there have been 95 commits pushed to the master branch:

• 85d5688: 8378330: Do not malloc the GrowableArrays in async_get_stack_trace
• b4c3629: 8377702: Disable AArch64 SpinPause tests on Windows
• b99d1f0: 8378354: Faulty assertion in checkInvariants method of ConcurrentHashMap
• ... and 92 more: https://git.openjdk.org/jdk/compare/63f00fff921ed4ac0f595a0a013d399700433a2c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mhaessig @dev-jonghoonpark Pushed as commit f1169f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.