Include extraParams.hxml when library path is overridden.#2010
Open
player-03 wants to merge 1 commit intoopenfl:developfrom
Open
Include extraParams.hxml when library path is overridden.#2010player-03 wants to merge 1 commit intoopenfl:developfrom
player-03 wants to merge 1 commit intoopenfl:developfrom
Conversation
player-03
force-pushed
the
Haxelib_pathOverrides_extraParams
branch
from
6635946 to
2e856bd
Compare
player-03
changed the title
Member
|
It would be ideal if we could pass this onto haxelib, then we wouldn't have to worry about missing behaviour in future |
Contributor
Author
|
Agreed, that would be ideal. But as far as I know, you can't pass a file path to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When including a haxelib with an overridden path (such as Lime itself, when using a local Haxelib repo), Lime fails to copy extraParams.hxml, potentially breaking compilation. This checks for the file and copies all non-comment lines if found.
Closes #2004, supersedes #2009.