Add webhook triggers to bypass ValueErrors#406
Merged
AaronDDM merged 3 commits intonylas:mainfrom Apr 9, 2025
Merged
Conversation
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
approved these changes
Jan 31, 2025
Contributor
AaronDDM
left a comment
AaronDDM
left a comment
There was a problem hiding this comment.
Are there any tests that need to be updated?
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
Contributor
Author
|
@AaronDDM There is deserialization test but I just added one that covers the entire list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were missing some webhook triggers which caused ValueErrors while customers tried to use our Webhooks API via the SDK.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.