refactor(#2826): multi instance view#3109
Closed
alex-courtis wants to merge 27 commits intomasterfrom
Closed
Conversation
Member
Author
|
Apologies @raaymax I abandoned trying to rebase #2864 , I applied the changes by hand. Notable:
I'd be most grateful for your review; any problems you remember would be good to check. |
Member
Author
|
Member
Author
|
This is working, however it's not useful due to the extensive use of the globals. Alternative approach: extract the global functions into a separate global module, to be addressed in the next milestone. |
Member
Author
|
Needs a re-think and alternative approach. |
Member
Author
|
Split instance Window and global View. Dogfooding. |
Member
Author
|
Splitting out view was a step backwards. Revert that and continue in #3153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2826
View does not mutate options, hence no need to deep clone anything.
Preserved the tab states bits; they still function as there is still one and only one explorer.
Testing methodology:
error("$callsite")at each call to a View method