fix(#2746): background and right aligned icons in floating windows

[simonmandlik]

Closes #2746

Also I added functionality for copying over right-aligned icons to the float.

Before:

After:

[simonmandlik]

On second thought, copying over right aligned icons is not a very good idea—they are nearly always visible anyway and as implemented in this PR, they might be copied in a different order than in the tree window.

I pushed another commit getting rid of that copying.

There is also one more improvement in the condition when to show the full name in float. It now takes into account also right aligned icons.

Before:

After:

[alex-courtis]

On second thought, copying over right aligned icons is not a very good idea—they are nearly always visible anyway and as implemented in this PR, they might be copied in a different order than in the tree window.

Good call. It's non-trivial and doesn't really add much value.

[alex-courtis]

There is also one more improvement in the condition when to show the full name in float. It now takes into account also right aligned icons.

Apologies, I think I might not be understanding; it seems to be adding whitespace to the float, for the right icons:

-- vim.opt.culopt = "number"
require("nvim-tree").setup({
  view = {
    width = 18,
  },
  renderer = {
    full_name = true,
    icons = {
      git_placement = "right_align",
      modified_placement = "right_align",
      hidden_placement = "right_align",
      diagnostics_placement = "right_align",
      bookmarks_placement = "right_align",
    },
  },
})

No icon:

Icon:

[alex-courtis]

Great work as always @simonmandlik

please:

• move extmarks_length to util
• fix the annotation nit

[alex-courtis]

Suggested change

	---@param extmarks table
	---@param vim.api.keyset.get_extmark_item[] as per vim.api.nvim_buf_get_extmarks

[alex-courtis]

Thanks for abstracting this.

Small request: move this to utils.lua. View is being converted into a stateful explorer member as part of the multi-instance view initiative: #3109

[alex-courtis]

Apologies, my time is limited, I'll look at this next weekend.

[simonmandlik]

There is also one more improvement in the condition when to show the full name in float. It now takes into account also right aligned icons.

Apologies, I think I might not be understanding; it seems to be adding whitespace to the float, for the right icons:

-- vim.opt.culopt = "number"
require("nvim-tree").setup({
  view = {
    width = 18,
  },
  renderer = {
    full_name = true,
    icons = {
      git_placement = "right_align",
      modified_placement = "right_align",
      hidden_placement = "right_align",
      diagnostics_placement = "right_align",
      bookmarks_placement = "right_align",
    },
  },
})

No icon:

Icon:

Thanks for pointing that out, there was a bug, which now should be fixed. This PR, besides fixing #2746, also fixes this behavior:

master:

PR:

[alex-courtis]

Many thanks for the thorough fix!