use main branch for treesitter to remove depracted vim.validate api#1579
use main branch for treesitter to remove depracted vim.validate api#1579johnpekcan wants to merge 1 commit intonvim-lua:masterfrom
Conversation
|
Still see the error for nvim-tree, but they have a fix waiting for release: nvim-tree/nvim-tree.lua#3120 |
init.lua
Outdated
There was a problem hiding this comment.
I have also been looking into this and I think the main branch, doesn't support those options at the time. Or am I missing something?
There was a problem hiding this comment.
I think you're right. seeing some unexpected behavior in treesitter now. My helm template files are actually rendering correctly as yaml now -- but setting filetype :set filetype=helm seems to break the syntax highlight again. :/
There was a problem hiding this comment.
maybe main branch isn't ready for prime time shrug
There was a problem hiding this comment.
return {
"nvim-treesitter/nvim-treesitter",
build = ":TSUpdate",
branch = "main",
config = function()
require("nvim-treesitter").install({
"c",
"lua",
"vim",
"vimdoc",
"query",
"elixir",
"heex",
"javascript",
"html",
"rust",
"dart",
})
end,
}This is the closest I got to replicating the old behavior, but the other options are missing tho. Maybe this helps.
There was a problem hiding this comment.
thank you! that certainly got us closer. but definitely different behavior still.
1Naim
left a comment
There was a problem hiding this comment.
As mentioned by clason in your linked issue, the main branch is not a drop-in replacement, therefore the existing config will not work. You will have to rewrite it if you want to get this merged.
|
Totally valid! I totally glossed over that 😅 Cheers! |
Recently noticed api deprecated warning while checking
:checkhealthand opened a ticket with treesitter:nvim-treesitter/nvim-treesitter#7916
Upon reading further, I found out that they have deprecated the
masterbranch and are usingmain-- which removed the deprecated api. I'm updating kickstart to reflect their recommended install settings:https://github.com/nvim-treesitter/nvim-treesitter/tree/main?tab=readme-ov-file#installation