Update XML2Array.php#5
Merged
nullivex merged 1 commit intonullivex:masterfrom Nov 2, 2016
justplaymore:patch-1
Merged
Conversation
Contributor
justplaymore
commented
May 16, 2016
justplaymore
commented
- add second parameter to XML2Array::createArray for DOMDocument::load, e.g: LIBXML_NOCDATA
- change method visibility from private to protected for overloading
- add second parameter to XML2Array::createArray for DOMDocument::load, e.g: LIBXML_NOCDATA - change method visibility from private to protected for overloading
Owner
|
This looks good. I will try to get this merged and a new version cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.