Update @npmcli/package-json to fix prepare issue found in npm@9.7.0#6518
Merged
lukekarrys merged 3 commits intolatestfrom Jun 6, 2023
Merged
Update @npmcli/package-json to fix prepare issue found in npm@9.7.0#6518lukekarrys merged 3 commits intolatestfrom
@npmcli/package-json to fix prepare issue found in npm@9.7.0#6518lukekarrys merged 3 commits intolatestfrom
Conversation
lukekarrys
force-pushed
the
lk/npm-manifest-snapshot
branch
from
903b1c3 to
f2aa1ee
Compare
lukekarrys
force-pushed
the
lk/npm-manifest-snapshot
branch
from
f2aa1ee to
e242ef1
Compare
lukekarrys
force-pushed
the
lk/npm-manifest-snapshot
branch
from
e242ef1 to
97acdd9
Compare
These dependency updates fix the issue found in `9.7.0` that was the reason for its deprecation. Specifically `npm` will now use `bin` before `directories.bin` when looking for bin scripts. This matches the behavior of `npm@9.6.7`.
lukekarrys
force-pushed
the
lk/npm-manifest-snapshot
branch
from
97acdd9 to
91bf5eb
Compare
lukekarrys
changed the title
@npmcli/package-json to fix prepare issue found in npm@9.7.0
wraithgar
approved these changes
Jun 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting to a draft while the commits include temporary tarball dependencies to run smoke-tests against.Will be ready for review once: npm/package-json#36 and npm/git#137 land.This PR contains two failing tests for the issue found in
9.7.0and the dependency updates for@npmcli/package-jsonthat fix it.