This repository was archived by the owner on Aug 11, 2020. It is now read-only.
Conversation
addaleax
reviewed
Oct 10, 2019
After ngtcp2 being updated, `ngtcp2_conn_get_idle_timeout` is renamed as `ngtcp2_conn_get_idle_expiry` which returns `ngtcp2_tstamp` instead of `ngtcp2_duration`. Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604
oyyd
force-pushed
the
fix-idle-timeout
branch
from
24acab3 to
84bd7af
Compare
addaleax
approved these changes
Oct 10, 2019
addaleax
pushed a commit
that referenced
this pull request
Oct 10, 2019
After ngtcp2 being updated, `ngtcp2_conn_get_idle_timeout` is renamed as `ngtcp2_conn_get_idle_expiry` which returns `ngtcp2_tstamp` instead of `ngtcp2_duration`. Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604 PR-URL: #166 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in 6b97000, thanks! :) |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
After ngtcp2 being updated, `ngtcp2_conn_get_idle_timeout` is renamed as `ngtcp2_conn_get_idle_expiry` which returns `ngtcp2_tstamp` instead of `ngtcp2_duration`. Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604 PR-URL: #166 Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
After ngtcp2 being updated, `ngtcp2_conn_get_idle_timeout` is renamed as `ngtcp2_conn_get_idle_expiry` which returns `ngtcp2_tstamp` instead of `ngtcp2_duration`. Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604 PR-URL: nodejs#166 Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
After ngtcp2 being updated, `ngtcp2_conn_get_idle_timeout` is renamed as `ngtcp2_conn_get_idle_expiry` which returns `ngtcp2_tstamp` instead of `ngtcp2_duration`. Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604 PR-URL: nodejs#166 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After ngtcp2 being updated,
ngtcp2_conn_get_idle_timeoutis renamed asngtcp2_conn_get_idle_expirywhich returnsngtcp2_tstampinstead ofngtcp2_duration.Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604
Fixes: #164
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes