This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: default options parameter in constructor#152
Closed
trivikr wants to merge 1 commit intonodejs:masterfrom
trivikr:quic-constructor-options-default
Closed
quic: default options parameter in constructor#152trivikr wants to merge 1 commit intonodejs:masterfrom trivikr:quic-constructor-options-default
trivikr wants to merge 1 commit intonodejs:masterfrom
trivikr:quic-constructor-options-default
Conversation
jasnell
approved these changes
Oct 6, 2019
danbev
approved these changes
Oct 7, 2019
trivikr
added a commit
that referenced
this pull request
Oct 7, 2019
PR-URL: #152 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Member
Author
|
Landed in 92c25a6 |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
PR-URL: #152 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
PR-URL: nodejs#152 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
PR-URL: nodejs#152 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need not default options parameter as
{}is passed by default in createSocketquic/lib/internal/quic/core.js
Lines 2311 to 2315 in 40e5be0
Moving this change in the function signature.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes