Skip to content

Blog: Fix v8.dev link in v12.5.0 release post#2300

Merged
SEWeiTung merged 2 commits intonodejs:masterfrom
Cherry:fix-external-v8-link
Jun 29, 2019
Merged

Blog: Fix v8.dev link in v12.5.0 release post#2300
SEWeiTung merged 2 commits intonodejs:masterfrom
Cherry:fix-external-v8-link

Conversation

@Cherry
Copy link
Contributor

@Cherry Cherry commented Jun 27, 2019

This fixes the v8.dev link to not act as a relative URL in https://nodejs.org/en/blog/release/v12.5.0/. Currently in links to https://nodejs.org/en/blog/release/v12.5.0/v8.dev/features/numeric-separators, but this PR fixes it to https://v8.dev/features/numeric-separators

@devsnek
Copy link
Member

devsnek commented Jun 27, 2019

thank you! would you mind also adding links to the notable changes' prs? see https://github.com/nodejs/node/pull/28450/files

@Cherry
Copy link
Contributor Author

Cherry commented Jun 27, 2019

Done, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants