test: use strictEqual() domain-http#9996
Conversation
did this at nina 2016 na code and learn event
imyller
added
the
code-and-learn
|
Your name on this commit currently shows To change, you can do: git commit --amend --no-edit --author="Monico Moreno <cdnadmin@collaborare.net>" |
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Commit message could be improved, but LGTM
|
@gibfahn thx for the suggestion; I think will do what you mentioned from here on. For this go-round, since you're good with just GH username, I'm going to leave it as-is. @cjihrig I agree that the commit message could be improved. We were under a bit of time crunch due to lack of wif-fi bandwidth at Code & Learn. I'll leave it as-is since you had mercy and gave it a LGTM ;-). Thx y'all! |
|
@cdnadmin I suggest you run this on your machine (it'll change your defaults so you never have to worry about it again). git config --global user.name "Monico Moreno"
git config --global user.email "cdnadmin@collaborare.net" |
|
Cool! Thx, @gibfahn ! 👍 I actually already have my git defaults set, but I typically set the user.name and user.email props locally and leave it at that. Now that I'm going to try and contribute actively to node, I might set my defaults globally, like you suggested above. |
|
Hey, @Trott RE:Jenkins Not sure if there is anything I need to do from my end or just wait for this PR to be landed. Standing by for advice ;-) ... |
|
@cdnadmin It's all green, so you should be good. We normally let PRs sit for at least 48 hours, so (hopefully) someone will merge this in in a day or two if no-one objects. |
|
Thx, @gibfahn, yup, I'm green in more ways than one! Ha! Kidding! Looking forward to seeing this bad boy landed! 💪🏻 |
did this at nina 2016 na code and learn event PR-URL: #9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 40daf6b. Thank you for the PR and for participating in the code-and-learn! |
did this at nina 2016 na code and learn event PR-URL: #9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
did this at nina 2016 na code and learn event PR-URL: nodejs#9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
did this at nina 2016 na code and learn event PR-URL: nodejs#9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
did this at nina 2016 na code and learn event PR-URL: #9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
did this at nina 2016 na code and learn event PR-URL: #9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
did this at nina 2016 na code and learn event PR-URL: #9996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
10 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
did this at nina 2016 na code and learn event