doc: correct metadata of Buffer.from#9167
Closed
addaleax wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
doc: correct metadata of Buffer.from#9167addaleax wants to merge 1 commit intonodejs:v4.x-stagingfrom
Buffer.from#9167addaleax wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
`Buffer.from` was present in `v3.0.0` but didn’t work for any combination of arguments as it was inherited from `Uint8Array`. This corrects the data to contain the version in which Node’s own `Buffer.from` was added, namely `v4.5.0`. Fixes: nodejs#9165
nodejs-github-bot
added
buffer
cjihrig
approved these changes
Oct 18, 2016
jasnell
approved these changes
Oct 18, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Oct 24, 2016
`Buffer.from` was present in `v3.0.0` but didn’t work for any combination of arguments as it was inherited from `Uint8Array`. This corrects the data to contain the version in which Node’s own `Buffer.from` was added, namely `v4.5.0`. Fixes: #9165 PR-URL: #9167 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
landed in b401d9b |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
`Buffer.from` was present in `v3.0.0` but didn’t work for any combination of arguments as it was inherited from `Uint8Array`. This corrects the data to contain the version in which Node’s own `Buffer.from` was added, namely `v4.5.0`. Fixes: #9165 PR-URL: #9167 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, buffer
Description of change
Buffer.fromwas present inv3.0.0but didn’t work for anycombination of arguments as it was inherited from
Uint8Array.This corrects the data to contain the version in which Node’s
own
Buffer.fromwas added, namelyv4.5.0.Fixes: #9165