Add Eslint rule prefer-assert-methods#8622
Add Eslint rule prefer-assert-methods#8622danyshaanan wants to merge 5 commits intonodejs:masterfrom danyshaanan:eslint
Conversation
yorkie
left a comment
yorkie
left a comment
There was a problem hiding this comment.
LGTM except an ESLint error...
| '!==': 'notStrictEqual', | ||
| '==': 'equal', | ||
| '!=': 'notEqual' | ||
| } |
There was a problem hiding this comment.
Semi-colon is missing i guess :)
There was a problem hiding this comment.
Oops!! :O
Fixed.
|
Fixed all violations in dada443, so now |
|
This failed in CI on the 'test/arm-fanned' check, on which most builds failed lately, after a lengthy period of time. This also applies to this PR I've opened. Am I correct in guessing that this is an issue with the 'test/arm-fanned' execution and not the PRs? How can it be determined with better certainty? |
Yes.
Unfortunately, I think in this case it requires familiarity with the issue affecting those devices. But generally, it's a matter of looking at the console results in the Jenkins interface. I suspect the issue will be resolved-ish soon. The resolution will turn the builds yellow, not green, but close enough for jazz. It's a case of those devices running the tests with |
|
LGTM |
|
The python install was for some reason broken on that machine; had to manually fix it (reinstall didn't work) |
|
LGTM |
1 similar comment
|
LGTM |
PR-URL: #8622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
|
Landed in d469321! Thank you! |
|
@danyshaanan glad to see you put this together! |
PR-URL: #8622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
9 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passes(Commits will be squashed and properly named after some more review)
Description of change
@Trott
Add ESLint rule for catching uses of
assert()with binary operators (===,!===,==,!=) which could be replaces with assert's methods -strictEqual/notStrictEqual/equal/notEqual.Here is some of the output for:
for a total of 86 errors.
If the rule will be deemed good, I'd be happy to fix these violations.(fixed).WDTY?