process: changed var to const in internal/process/promises#8620
Closed
AdriVanHoudt wants to merge 1 commit intonodejs:masterfrom
Closed
process: changed var to const in internal/process/promises#8620AdriVanHoudt wants to merge 1 commit intonodejs:masterfrom
AdriVanHoudt wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Sep 17, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM but the commit message should start with process:
AdriVanHoudt
force-pushed
the
const_promises
branch
from
4992f58 to
4892d03
Compare
AdriVanHoudt
changed the title
Contributor
Author
|
@addaleax changed |
Contributor
|
LGTM |
Member
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2016
PR-URL: #8620 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in d4bf5ca! thank you! |
Contributor
Author
|
you're welcome! |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8620 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
processDescription of change
Changed var to const.
Part of nodejs/code-and-learn#56