test: cleanup test-child-process-buffering#8578
Closed
AdriVanHoudt wants to merge 1 commit intonodejs:masterfrom
Closed
test: cleanup test-child-process-buffering#8578AdriVanHoudt wants to merge 1 commit intonodejs:masterfrom
AdriVanHoudt wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
the
child_process
addaleax
approved these changes
Sep 17, 2016
Member
|
That arm failure was weird, so CI again: https://ci.nodejs.org/job/node-test-commit/5176/ |
Member
|
I'll start landing this.
|
imyller
pushed a commit
to imyller/node
that referenced
this pull request
Sep 20, 2016
PR-URL: nodejs#8578 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Member
|
landed in 1c81dd8 Thank you for your contribution, @AdriVanHoudt |
Contributor
Author
|
@imyller thanks, np! |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8578 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
testDescription of change
Cleanup according to nodejs/code-and-learn#56