doc: remove extra comma in cluster docs#8557
Closed
not-an-aardvark wants to merge 1 commit intonodejs:masterfrom
Closed
doc: remove extra comma in cluster docs#8557not-an-aardvark wants to merge 1 commit intonodejs:masterfrom
not-an-aardvark wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
cluster
Contributor
|
LGTM |
lpinca
approved these changes
Sep 16, 2016
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
I think that both variants (with or without the comma) are correct but LGTM.
Contributor
|
LGTM |
evanlucas
approved these changes
Sep 16, 2016
Contributor
Author
|
Landed in 84afdc3 |
not-an-aardvark
added a commit
that referenced
this pull request
Sep 18, 2016
PR-URL: #8557 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8557 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
Removes an extraneous comma.