test: revert fix test-net-* error code check#7503
test: revert fix test-net-* error code check#7503MylesBorins wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
This reverts commit 0414d88. This is a super weird one. This commit landed with no problems with the test suite. CI tested absolutely fine multiple times. As of June 30 2016 the test suite is now reliably failing on `test-net-*`. This is extremely odd to be coming up after the release and multiple test runs. Weirdness aside, the revert brings the test suite back to a reliable state. This may cause problems for testing on Alpine, this will need to be revisited.
|
ci: https://ci.nodejs.org/job/node-test-pull-request/3144/ I'm going to head for lunch now. I am planning to land this once I get back so I can get unblocked and start backporting more stuff to v4.x in preperation for the v4.5.0 rc If people can throw an LGTM on this I'd appreciate it /cc @nodejs/lts @mhart |
|
It hopefully shouldn't cause problems on Alpine >= 3.4.1 thanks to http://bugs.alpinelinux.org/issues/5725 |
|
To add to the weirdness... it would appear my machine is now failing on master for this as well. I am at a bit of a loss as to what is going on, perhaps this is some local management stuff happening on my machine |
|
I'm out of face to palm.... it would appear that the wifi network I am on right now is blocking this connection and causing the timeouts... ughhhhhh
|
2 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This reverts commit 0414d88.
This is a super weird one. This commit landed with no problems with the
test suite. CI tested absolutely fine multiple times. As of June 30
2016 the test suite is now reliably failing on
test-net-*.This is extremely odd to be coming up after the release and multiple
test runs.
Weirdness aside, the revert brings the test suite back to a reliable
state. This may cause problems for testing on Alpine, this will need
to be revisited.