doc: improved stdout markdown consistency in api/console.md#7062
Closed
JonathanMontane wants to merge 1 commit intonodejs:masterfrom
JonathanMontane:patch-1
Closed
doc: improved stdout markdown consistency in api/console.md#7062JonathanMontane wants to merge 1 commit intonodejs:masterfrom JonathanMontane:patch-1
JonathanMontane wants to merge 1 commit intonodejs:masterfrom
JonathanMontane:patch-1
Conversation
`stdout` was written as `inline code` most of the time, except for the `console.time` and `console.timeEnd` functions which made it a bit more tedious to read about. Now it's always using inline code.
Contributor
|
LGTM |
Contributor
|
@JonathanMontane Thanks for you contribution! However, it looks like you may have made this PR from the github editor, as your author information shows: Would you mind doing setting your email to git? (You can also use a name other than your username, if you wish) $ git config --global user.email "j.random.user@example.com"
$ git config --global user.name "J. Random User"Then $ git commit --amend --reset-author
$ git push origin patch-1 --forceAlso, some nits about the commit message:
(We can fix these two on landing, but prefer if you did yourself!) |
Contributor
|
LGTM, w/ @Fishrock123 nits addressed. |
Member
|
LGTM. I'll correct the nits while landing |
jasnell
pushed a commit
that referenced
this pull request
Jun 6, 2016
`stdout` was written as `inline code` most of the time, except for the `console.time` and `console.timeEnd` functions which made it a bit more tedious to read about. Now it's always using inline code. PR-URL: #7062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in c3e86de with nits addressed |
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
`stdout` was written as `inline code` most of the time, except for the `console.time` and `console.timeEnd` functions which made it a bit more tedious to read about. Now it's always using inline code. PR-URL: #7062 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
stdoutoccurrences inconsole.timedescription use inline code.stdoutoccurrences inconsole.timeEnddescription use inline code.