lib: fix max size check in Buffer constructor#657
Merged
bnoordhuis merged 1 commit intonodejs:v1.xfrom Jan 31, 2015
Merged
Conversation
Member
Author
|
The commit log is admittedly a little weak. The failing CHECK is related to but not exclusively caused by the bad length check in lib/buffer.js. |
edda11f to
fca484e
Compare
Contributor
|
LGTM |
A number -> uint32 type coercion bug made buffer sizes larger than kMaxLength (0x3fffffff) wrap around. Instead of rejecting the requested size with an exception, the constructor created a buffer with the wrong size. PR-URL: nodejs#657 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
fca484e to
0767c2f
Compare
feross
added a commit
to feross/buffer
that referenced
this pull request
Feb 10, 2015
trevnorris
pushed a commit
to nodejs/node-v0.x-archive
that referenced
this pull request
Feb 10, 2015
A number -> uint32 type coercion bug made buffer sizes larger than kMaxLength (0x3fffffff) wrap around. Instead of rejecting the requested size with an exception, the constructor created a buffer with the wrong size. PR-URL: nodejs/node#657 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A logic error let buffer sizes larger than kMaxLength (0x3fffffff) slip
through. The .toString() operation (and possibly others as well) then
blew up because the buffer was larger than it could reasonably handle.
Fixes the following run-time assert:
Fixes: #649
R=@trevnorris?