Skip to content

crypto: Fix potential null pointer dereference when BIO_meth_new() fails #61788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndossche wants to merge 2 commits into
base: main
Choose a base branch
from
Open

crypto: Fix potential null pointer dereference when BIO_meth_new() fails #61788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ee6e91
crypto: fix potential null pointer dereference when BIO_meth_new() fails
ndossche Feb 12, 2026
6ffa012
fixup! Use CHECK_NOT_NULL()
ndossche Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deps/ncrypto/ncrypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,6 +1470,7 @@ BIOPointer BIOPointer::NewSecMem() {
}

BIOPointer BIOPointer::New(const BIO_METHOD* method) {
if (method == nullptr) return {};
return BIOPointer(BIO_new(method));
}

Expand Down
1 change: 1 addition & 0 deletions src/crypto/crypto_bio.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ const BIO_METHOD* NodeBIO::GetMethod() {
// Static initialization ensures that this is safe to use concurrently.
static const BIO_METHOD* method = [&]() {
BIO_METHOD* method = BIO_meth_new(BIO_TYPE_MEM, "node.js SSL buffer");
CHECK_NOT_NULL(method);
BIO_meth_set_write(method, Write);
BIO_meth_set_read(method, Read);
BIO_meth_set_puts(method, Puts);
Expand Down
Loading