Skip to content

watch: get flags from execArgv#61779

Open
efekrskl wants to merge 2 commits intonodejs:mainfrom
efekrskl:fix/watch-mode-env-collision
Open

watch: get flags from execArgv#61779
efekrskl wants to merge 2 commits intonodejs:mainfrom
efekrskl:fix/watch-mode-env-collision

Conversation

@efekrskl
Copy link
Contributor

Fixes #61412

This seems to be a regression from cec1bd5, where watch mode switched to spawning the child using getOptionsAsFlagsFromBinding() instead of process.execArgv and the original flag ordering is not preserved.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (9a237cd) to head (062f3a5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61779      +/-   ##
==========================================
- Coverage   89.73%   89.73%   -0.01%     
==========================================
  Files         675      675              
  Lines      204674   204674              
  Branches    39330    39327       -3     
==========================================
- Hits       183667   183665       -2     
- Misses      13283    13295      +12     
+ Partials     7724     7714      -10     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 12, 2026
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotenv: override does not behave correctly with watch enabled

6 participants