test_runner: exclude mocked CJS modules from coverage#61723
Open
ThanhNguyxn wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: exclude mocked CJS modules from coverage#61723ThanhNguyxn wants to merge 1 commit intonodejs:mainfrom
ThanhNguyxn wants to merge 1 commit intonodejs:mainfrom
Conversation
When a CommonJS module is mocked and imported into an ESM module, the coverage report incorrectly includes the mocked module. This happens because V8 coverage reports use the original file URL without the mock search parameter that ESM loader adds. This fix checks if the base URL (without query params) is registered in the mocks registry in addition to checking the URL search params. Fixes: nodejs#61709
Collaborator
|
Review requested:
|
himself65
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
When a CommonJS module is mocked and imported into an ESM module, the coverage report incorrectly includes the mocked module. This happens because V8 coverage reports use the original file URL without the mock search parameter (
?node-test-mock=X) that the ESM loader adds.Root Cause
PR #59348 fixed issue #59112 by checking if a coverage URL contains the
kMockSearchParamquery parameter to exclude mocked modules. However, this only works for ESM-to-ESM mocking because:resolvehook adds the mock search param to the URLSolution
In
shouldSkipFileCoverage(), after checking the URL search params, also check if the base URL (without query params) is registered in themocksregistry withactive: true.Reproduction (from #61709)
Fixes: #61709