-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
src: fix cjs_lexer external reference registration #61718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It needs to be added to the list to actually get registered.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61718 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.01%
==========================================
Files 674 675 +1
Lines 204348 204502 +154
Branches 39271 39305 +34
==========================================
+ Hits 183396 183519 +123
- Misses 13262 13273 +11
- Partials 7690 7710 +20
🚀 New features to boost your workflow:
|
anonrig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For educational purposes: How did you encounter this issue, and what problem did you see?
|
I was trying to create a snapshot with the ESM loader. When it's not properly registered adding it to the snapshot would break (see src/README.md's section about external references on what it looks like, or with my PR in #61719 it will suggest the binding is not in there). |
Thanks! |
|
Landed in b864049 |
To help catch unregistered bindings. PR-URL: nodejs#61719 Refs: nodejs#61718 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It needs to be added to the list to actually get registered.