test: fix location object to match Location interface in WPT#61490
Open
kimtaejin3 wants to merge 1 commit intonodejs:mainfrom
Open
test: fix location object to match Location interface in WPT#61490kimtaejin3 wants to merge 1 commit intonodejs:mainfrom
kimtaejin3 wants to merge 1 commit intonodejs:mainfrom
Conversation
The Location interface should not have a searchParams property according to the WHATWG URL spec. This commit fixes the WPT test runner to hide the searchParams property from the location object using a Proxy, ensuring that WPT tests expecting the Location interface behavior pass correctly. - Use Proxy to hide searchParams from location object in WPT runner - Remove historical.any.js from expected failures in url.json Fixes the 'searchParams on location object' test in historical.any.js
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
I don't believe this to be necessary, fixing a test stub for the purpose of having the stub's wpt pass isn't helping the runtime. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61490 +/- ##
==========================================
+ Coverage 87.99% 89.82% +1.82%
==========================================
Files 704 667 -37
Lines 208739 203693 -5046
Branches 40184 39151 -1033
==========================================
- Hits 183679 182962 -717
+ Misses 17006 13064 -3942
+ Partials 8054 7667 -387 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Location interface should not have a searchParams property according to the WHATWG URL spec. This commit fixes the WPT test runner to hide the searchParams property from the location object using a Proxy, ensuring that WPT tests expecting the Location interface behavior pass correctly.
Fixes the 'searchParams on location object' test in historical.any.js